Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Assignees rename fields #1076

Merged
merged 2 commits into from
Jun 16, 2016
Merged

Assignees rename fields #1076

merged 2 commits into from
Jun 16, 2016

Conversation

Shredder121
Copy link
Contributor

I saw that the original user was not in the assignees list, and that the users in the assignees list weren't consistent.
This updates (merges) the USER with itself, updating all fields with the block. (if anyone knows of a nicer way, let me know)
This makes the data a little more realistic.

@MikeMcQuaid
Copy link
Contributor

@gjtorikian Any thoughts here?

@gjtorikian
Copy link
Contributor

It's definitely clever, but I think we should just opt for explicitness. @Shredder121, would you mind simply copying the USER constant and naming it HUBOT, and just manually replacing the words with hubot? That would allow us to use these other users in the future. Thank you!

@Shredder121
Copy link
Contributor Author

Should I also use the values from https://api.github.com/users/hubot?

@Shredder121
Copy link
Contributor Author

And what about other_user?

@gjtorikian
Copy link
Contributor

@Shredder121 Nah, you can keep the hubot stuff much simpler, no need to actually add all the repositories and what not. Same with other_user, just copy the same stuff in USER and replace the username.

@Shredder121
Rename the USERS to the right user
aae43ca 
This introduces new constants, so that they can be used in other
places as well.
This makes the data a little more realistic.
@Shredder121 Shredder121 force-pushed the assignees-rename-fields branch from 9316208 to aae43ca Compare June 16, 2016 07:16
@Shredder121
Copy link
Contributor Author

There, how's that?

@Shredder121
Copy link
Contributor Author

What happened to Travis?
https://travis-ci.org/github/developer.github.com

@MikeMcQuaid
Copy link
Contributor

@Shredder121 not sure but reactivated it now.

@gjtorikian
Copy link
Contributor

Beautiful. Thanks as always @Shredder121!

@gjtorikian gjtorikian merged commit c4f3fcd into github:master Jun 16, 2016
@Shredder121
Copy link
Contributor Author

Haha, no problem as always! 👍

@Shredder121 Shredder121 deleted the assignees-rename-fields branch June 16, 2016 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shredder121 @MikeMcQuaid @gjtorikian
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy