Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Grammar, JSON, and status code corrections #90

Closed
wants to merge 5 commits into from

Conversation

sigmavirus24
Copy link
Contributor

s/this/these on a couple lines in content/v3/orgs/teams.md

Also added a correction to the ORG json. The original url link was incorrect.

And finally, for editing a team, the status code that is actually returned is 200, not 201.

$ curl "https://api.github.com/orgs/github"
{
  "public_gists": 0,
  "type": "Organization",
  "public_repos": 55,
  "url": "https://api.github.com/orgs/github",
  "blog": "https://github.com/about",
  "avatar_url": "https://secure.gravatar.com/avatar/...",
  "company": null,
  "login": "github",
  "email": "support@github.com",
  "followers": 674,
  "name": "GitHub",
  "created_at": "2008-05-11T04:37:31Z",
  "location": "San Francisco, CA",
  "id": 9919,
  "following": 0,
  "html_url": "https://github.com/github"
}

Note that url is not https://api.github.com/orgs/1 (or any numeral for that
matter). This holds the pattern of https://api.github.com/users/github

(I shortened the avatar_url link since it wasn't relevant.)
API actually returns status code 200.
So far, just from looking at commits on Pull Requests, it seems as if the
'author' and 'committer' fields are returning USER like data structures instead
of the structure that was there previously.
I'm not entirely sure yet that this is the response that is sent, but I'm
guessing that it is. I would have expected this to be documented, but I hope
this will get the attention of someone who can fix it if it isn't correct.
@sigmavirus24
Copy link
Contributor Author

820c3bd was wrong. I hadn't read the surrounding documentation well enough.

@technoweenie
Copy link
Contributor

Yup, thanks! I'll just merge those commits manually and skip 820c3bd.

@sigmavirus24
Copy link
Contributor Author

No problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy