Skip to content

fix: stop svg-element-attributes v2.0.0 from installing #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2021
Merged

fix: stop svg-element-attributes v2.0.0 from installing #118

merged 3 commits into from
Mar 31, 2021

Conversation

andykenward
Copy link
Contributor

When using the package in a new project svg-element-attributes v2.0.0 is installed causing eslint to error with the below error. This is because svg-element-attributes v2.0.0 is ESM only and must use import instead of require when using.

Doing a npm i -D svg-element-attributes@^1.3.1 to the new project solves the issue.

I suggest changing the semver version of svg-element-attributes from >=1.3.1 to ^1.3.1. To avoid users of this package from having this issue.

node v14.16.0
npm 6.14.12

...node_modules/svg-element-attributes/index.js
require() of ES modules is not supported.
require() of example-repo/node_modules/svg-element-attributes/index.js from example/node_modules/eslint-plugin-github/lib/rules/get-attribute.js is an ES module file as it is a .js file whose nearest parent package.json contains “type”: “module” which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove “type”: “module” from example-repo/node_modules/svg-element-attributes/package.json.

    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1216:13)
    at Module.load (internal/modules/cjs/loader.js:1039:32)
    at Module._load (internal/modules/cjs/loader.js:932:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12738)
    at Module.require (internal/modules/cjs/loader.js:1079:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (example-repo/node_modules/eslint-plugin-github/lib/rules/get-attribute.js:1:30)
    at Module._compile (internal/modules/cjs/loader.js:1199:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1039:32)

Signed-off-by: Andy Kenward 4893048+andykenward@users.noreply.github.com

@andykenward
fix: stop svg-element-attributes v2.0.0 from installing
b3f5f9a 
When using the package in a new project svg-element-attributes v2.0.0 is installed causing eslint to error with “ES module”

Signed-off-by: Andy Kenward <4893048+andykenward@users.noreply.github.com>
@andykenward andykenward marked this pull request as ready for review March 30, 2021 20:09
@andykenward andykenward requested a review from a team as a code owner March 30, 2021 20:09
koddsson
koddsson approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@koddsson koddsson merged commit 40e8afb into github:main Mar 31, 2021
@andykenward andykenward deleted the svg-element-attributes branch March 31, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

@bscofield bscofield Awaiting requested review from bscofield bscofield is a code owner automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andykenward @koddsson
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy