Stricter html string check #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that HTML literal strings correctly handle leading whitespace by updating the regex match pattern.
- Updated regex in unescaped-html-literal.js to allow for preceding whitespace before an HTML tag.
- Fixes potential false negatives in matching real-world HTML snippets.
Comments suppressed due to low confidence (1)
lib/rules/unescaped-html-literal.js:18
- Consider adding a comment explaining that the updated regex now supports leading whitespace before an HTML tag to aid future maintainability.
const htmlOpenTag = /^\s*<[a-zA-Z]/
|
ping @manuelpuyol (I see you are maintaining this project 🙏 ) |
|
Also cc @jibrang and @manuelpuyol What do you think about this change? I think it is important to handle this edge case, otherwise there could still be HTML abuses or even XSS. |
arelia
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #638
/^\s*<[a-zA-Z]/.test(" \n\t<a")=> trueThe real world case is like this: