Membership Validators #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How could I forget.
| # | ||
| # Returns a Net::LDAP::Filter. | ||
| def member_filter(entry = nil) | ||
| if entry | ||
| entry = entry.dn if entry.respond_to?(:dn) |
There was a problem hiding this comment.
A better variable name here might be dn since you extract it from an entry. Also, what do you think of making the parameter name entry_or_dn to reflect it accepting two types?
|
Made a first pass with an emphasis towards code quality and how the interface will be used. Overall, the idea feels pretty natural to me. Let me know if I'm totally off base b/c of missing context. |
Didn't match DN so resulted in false positives.
|
@jch cleaned up the diff based on your feedback, looking into a few more test and docs tweaks, but want to get this merged into |
|
👍 Merge at will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
GitHub::Ldap::MembershipValidatorsas an extraction of behavior focused on validating that an entry is a member of a list of groups.The goal here is to encapsulate a single operation, membership validation, into efficient, standalone objects for reuse. Each strategy,
Classic(what's already available today withDomain#is_member?),Recursive(an optimized approach), and more to come (likeActiveDirectorywhich could use matching rule in chain (1.2.840.113556.1.4.1941)) should be drop-in-replacements for each other, allowing you to pick the one most suited to your needs and environment.memberattribute inRecursivestrategyI'll follow up with the
ActiveDirectorystrategy et al in other PRs.cc @jch @github/ldap