Skip to content

Add CI build for OpenLDAP integration #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add CI build for OpenLDAP integration #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58a5315
Hook up separate OpenLDAP install, build steps
mtodd Sep 27, 2014
8759205
RVM exec rake for testing ApacheDS tests
mtodd Sep 27, 2014
392410f
Simplify a bit
mtodd Sep 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,17 @@ rvm:
- 1.9.3
- 2.1.0

env:
matrix:
- TESTENV=openldap
- TESTENV=apacheds

install:
- if [ "$TESTENV" = "openldap" ]; then ./script/install-openldap; fi

script:
- if [ "$TESTENV" = "openldap" ]; then ./script/cibuild-openldap; fi
- if [ "$TESTENV" = "apacheds" ]; then ./script/cibuild-apacheds; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you have it also works, but the install and script sections can be dried up a bit:

# if file exists, run it
[ -f ./script/install-$TESTENV ] && ./script/install-$TESTENV
[ -f ./script/cibuild-$TESTENV ] && ./script/cibuild-$TESTENV

Same with the above.

cc Travis docs The Build Matrix for reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wary of trying to DRY every reference, feels like too much indirection without a ton of value add.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. I don't imagine this section to grow significantly more complex. Both of them are easily readable for me.


notifications:
email: false
4 changes: 4 additions & 0 deletions script/cibuild-apacheds
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh

cd ..
rake
3 changes: 3 additions & 0 deletions script/cibuild-openldap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env sh

echo "OpenLDAP test runner stub"
3 changes: 3 additions & 0 deletions script/install-openldap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env sh

echo "OpenLDAP installer stub"
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy