Pass through search options for GitHub::Ldap::Domain#user? #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2014 15:21
|
Note that I plan to target master for the merge, but will do so once #50 merges. |
| options = search_options.merge \ | ||
| filter: login_filter(@uid, login), | ||
| size: 1 | ||
| search(options).first |
There was a problem hiding this comment.
Is the separate options vs search_options hash needed? Seems like it'd be fine to combine them?
There was a problem hiding this comment.
I decided against modify the search_options in place in case the caller was using it as a common hash to build up other queries.
|
Once my comment above is addressed (whatever you decide is cool), merge this into |
jch
added a commit
that referenced
this pull request
Oct 15, 2014
Pass through search options for GitHub::Ldap::Domain#user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to specify additional search options when querying for a user. The test demonstrates how a client can limit the attributes returned.
cc @github/ldap @mtodd