feat: add reviewers parameter to UpdatePullRequest #285
+205
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoannaaKL
previously approved these changes
Jun 24, 2025
|
Hi @MayorFaj, can you please update the pr so we can get it merged? :) |
…ation- go run ./cmd/github-mcp-server generate-docs
|
@JoannaaKL the PR has been updated |
Could you update again because is out-of-date? Great PR! |
JoannaaKL
reviewed
Jul 21, 2025
| } | ||
|
|
||
| // If no updates and no reviewers, return error | ||
| if !updateNeeded && len(reviewers) == 0 { |
There was a problem hiding this comment.
Can we move this check before the line 316?
JoannaaKL
reviewed
Jul 21, 2025
| } else { | ||
| // If no update needed, just get the current PR | ||
| var ghResp *github.Response | ||
| pr, ghResp, err = client.PullRequests.Get(ctx, owner, repo, pullNumber) |
There was a problem hiding this comment.
We we need this else? If no updates are needed and no new reviewers were requested we will just return an error (please see comment below).
JoannaaKL
requested changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to request reviewers when updating a pull request. The changes include updates to the
UpdatePullRequestfunction to handle reviewers, modifications to the test cases to cover the new functionality, and updates to the documentation.Enhancements to
UpdatePullRequestfunction:UpdatePullRequestfunction. (pkg/github/pullrequests.go) [1] [2] [3]pkg/github/pullrequests.go)Documentation updates:
README.mdto include the newreviewersparameter in the documentation for updating pull requests. (README.md)Test case updates:
pkg/github/pullrequests_test.go) [1] [2] [3] [4] [5]Closes: #259