team mention pasting #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56a9980 to
b06f076
Compare
mattcosta7
commented
Nov 9, 2023
| @@ -123,7 +123,7 @@ function linkify(element: HTMLAnchorElement, label: string): string { | |||
| let markdown = '' | |||
|
|
|||
| // Don't linkify user mentions like "@octocat" | |||
| if (isUserMention(element)) { | |||
| if (isUserMention(element) || isTeamMention(element)) { | |||
There was a problem hiding this comment.
while here, are there other types that shouldn't become urls?
no problem! I don't have write access on this one @joshblack so if you're good to merge, please do when it makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/github/html_pipeline/issues/76
This pull request to the codebase includes changes to improve the handling of GitHub team mentions in the
paste()function. The most important changes include adding a new test case to check that team handles are not rendered as markdown, and updating thelinkify()function to check if a link is a team mention using the newisTeamMention()function.Main interface changes:
src/paste-markdown-html.ts: Updated thelinkify()function to check if a link is a team mention using the newisTeamMention()function, and returns the label as markdown if it is a team or user mention. [1] [2]Testing improvements:
test/test.js: Added a new test case to check that team handles are not rendered as markdown in thepaste()function.