Skip to content

config/default: Unset DisabledByDefault: true #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1b549a3
config/default: Unset `DisabledByDefault: true`
issyl0 Oct 10, 2022
7df97a7
rubocop.yml: Disable some cops locally that aren't in the styleguide
issyl0 Oct 10, 2022
53a0a37
Run `bundle exec rubocop -a` (or `-A`) on all the code in this repo
issyl0 Oct 10, 2022
e36d683
Fix `Naming/MemoizedInstanceVariableName` offenses
issyl0 Oct 10, 2022
ee3cac8
README: Note that `DisabledByDefault: true` is useful for granularity
issyl0 Oct 11, 2022
db3b338
CHANGELOG: Add an 'unreleased' section
issyl0 Oct 11, 2022
f40758f
config/default: Explicitly set `Enabled: false` for a bunch of rules
issyl0 Oct 11, 2022
05e8276
config/default: Add `Enabled: true` cops now configured by default
issyl0 Oct 11, 2022
e48f452
config/default: Set `Enabled: false` on a bunch of rules
issyl0 Oct 12, 2022
baa90b2
config/default: Fix `Layout/IndentationStyle` configuration
issyl0 Oct 12, 2022
5a1ede7
.rubocop.yml: Move `Enabled: false` cops into `config/default.yml`
issyl0 Oct 12, 2022
60a3a04
config/default: It's impossible to disable `Lint/Syntax`
issyl0 Oct 12, 2022
55b4ece
Revert "Run `bundle exec rubocop -a` (or `-A`) on all the code in thi…
issyl0 Oct 12, 2022
d95509e
Revert "Fix `Naming/MemoizedInstanceVariableName` offenses"
issyl0 Oct 12, 2022
70dc91b
config/default: Set `Enabled: false` for new RuboCop rules
issyl0 Oct 12, 2022
4274086
CHANGELOG: Note that no new rules are enabled in this release
issyl0 Oct 13, 2022
cdcad37
Merge branch 'master' into rubocop-default-enablement
bensheldon Oct 13, 2022
6bbad25
Disable all of the DisabledByDefault Rails cops too
bensheldon Oct 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# rubocop-github

## Unreleased

- Unset `DisabledByDefault: true` in `config/default.yml`. Prevents confusing behaviour where users of the gem didn't realise that RuboCop's default cops weren't being applied (including potentially custom cops in their projects). We've explicitly set `Enabled: false` for all the cops that were previously default disabled. This has the effect that consumers of this gem won't be surprised by new linting violations when they use this new version in their projects. (https://github.com/github/rubocop-github/pull/119)
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ Alternatively, only require the additional custom cops in your `.rubocop.yml` wi

💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? They have been moved to [a new gem](https://github.com/github/rubocop-rails-accessibility).

For more granular control over which of RuboCop's rules are enabled for your project, both from this gem and your own configs, consider using the `DisabledByDefault: true` option under `AllCops` in your project's `.rubocop.yml` file. This will disable all cops by default, and you can then explicitly enable the ones you want by setting `Enabled: true`. See [the RuboCop docs](https://docs.rubocop.org/rubocop/configuration.html#enabled) for more information.

### Legacy usage

If you are using a rubocop version < 1.0.0, you can use rubocop-github version
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy