Skip to content

config/default: Remove some redundant Enabled: true for cops #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
config/default: Remove some redundant Enabled: true for cops
- For cops with a styleguide link, where there's evidence that we want
  the rule to apply, we don't need to also explicitly declare
  `Enabled: true` for each of them. Since we removed `DisabledByDefault`,
  the enablements here for cops that are *enabled by default in RuboCop
  itself** are redundant.
- I could have gone further and removed the rules that RuboCop has
  enabled by default that _didn't_ have a styleguide link, but I feel
  like we need some evidence for why a rule is in place first for when
  people come looking at this gem's config to figure out why new rules
  are suddenly failing or not.
  • Loading branch information
issyl0 authored Oct 21, 2022
commit 25a3a08f7ac3aed0216a755e104e9fdbadd9bac5
18 changes: 3 additions & 15 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,14 @@ Layout/HeredocIndentation:
Enabled: false

Layout/IndentationConsistency:
Enabled: false
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#indentation

Layout/IndentationStyle:
Enabled: true
EnforcedStyle: spaces
IndentationWidth: 2
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#default-indentation

Layout/IndentationWidth:
Enabled: true
Width: 2
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#default-indentation

Expand Down Expand Up @@ -262,11 +260,9 @@ Layout/SingleLineBlockChain:
Enabled: false

Layout/SpaceAfterColon:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators

Layout/SpaceAfterComma:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators

Layout/SpaceAfterMethodName:
Expand All @@ -276,18 +272,16 @@ Layout/SpaceAfterNot:
Enabled: true

Layout/SpaceAfterSemicolon:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators

Layout/SpaceAroundBlockParameters:
Enabled: true

Layout/SpaceAroundEqualsInParameterDefault:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-around-equals

Layout/SpaceAroundKeyword:
Enabled: false
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators

Layout/SpaceAroundMethodCallOperator:
Enabled: false
Expand Down Expand Up @@ -317,7 +311,6 @@ Layout/SpaceInLambdaLiteral:
Enabled: false

Layout/SpaceInsideArrayLiteralBrackets:
Enabled: true
EnforcedStyle: no_space
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#no-spaces-braces

Expand Down Expand Up @@ -349,7 +342,6 @@ Layout/TrailingEmptyLines:
Enabled: true

Layout/TrailingWhitespace:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#trailing-whitespace

Lint/AmbiguousAssignment:
Expand Down Expand Up @@ -1090,7 +1082,6 @@ Style/DateTime:
Enabled: false

Style/DefWithParentheses:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#method-parens-when-arguments

Style/Dir:
Expand Down Expand Up @@ -1178,7 +1169,6 @@ Style/FloatDivision:
Enabled: false

Style/For:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#avoid-for

Style/FormatString:
Expand Down Expand Up @@ -1215,7 +1205,6 @@ Style/HashLikeCase:
Enabled: false

Style/HashSyntax:
Enabled: true
EnforcedStyle: ruby19_no_mixed_keys
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#symbols-as-keys

Expand Down Expand Up @@ -1316,7 +1305,6 @@ Style/MultilineIfModifier:
Enabled: false

Style/MultilineIfThen:
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#no-then-for-multi-line-if-unless

Style/MultilineInPatternThen:
Expand Down Expand Up @@ -1583,8 +1571,8 @@ Style/StringHashKeys:
Enabled: false

Style/StringLiterals:
Enabled: true
EnforcedStyle: double_quotes
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#double-quotes

Style/StringLiteralsInInterpolation:
Enabled: false
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy