STYLEGUIDE: raise maximum characters. #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule is very loosely conformed to and 100 seems fairly arbitrary. Instead, let's loosen it slightly and provide a justification for that loosening.
|
Picking a few random people from contributors: @joelhawksley @rmosolgo @tma @skalnik @BlakeWilliams @cheshire137: any thoughts? |
BlakeWilliams
approved these changes
Oct 30, 2020
|
Thanks @BlakeWilliams, @joelhawksley! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule is very loosely conformed to and 100 seems fairly arbitrary. Instead, let's loosen it slightly and provide a justification for that loosening.
CC @cheshire137 who pointed this out to me in https://github.com/github/github/pull/160489#discussion_r513778065.
As an unrelated comment: it would be lovely if we could (one day) punt rules like this to RuboCop itself and have it populate all existing TODOs/exceptions. This is exactly the type of rule best done by machines rather than humans 🤖 👩🏻🎨