github · Watemlifts · Dec 23, 2021 · Jan 21, 2022 · Feb 27, 2022 · Feb 27, 2022
diff --git a/test/scientist/experiment_test.rb b/test/scientist/experiment_test.rb
@@ -288,7 +288,7 @@ def @ex.enabled?
   end
 
   it "reports an error and returns the original value when an error is raised in a clean block" do
-    @ex.clean { |value| raise "kaboom" }
+    @ex.clean { |_value| raise "kaboom" }
 
     @ex.use { "control" }
     @ex.try { "candidate" }
@@ -328,7 +328,7 @@ def @ex.enabled?
     it "rescues errors raised in the cohort determination block" do
       @ex.use { 5670 }
       @ex.try { 5670 }
-      @ex.cohort { |res| raise "intentional" }
+      @ex.cohort { |_res| raise "intentional" }
 
       @ex.run
 
@@ -412,9 +412,9 @@ def @ex.enabled?
 
     it "calls multiple ignore blocks to see if any match" do
       called_one = called_two = called_three = false
-      @ex.ignore { |a, b| called_one   = true; false }
-      @ex.ignore { |a, b| called_two   = true; false }
-      @ex.ignore { |a, b| called_three = true; false }
+      @ex.ignore { |_a, _b| called_one   = true; false }
+      @ex.ignore { |_a, _b| called_two   = true; false }
+      @ex.ignore { |_a, _b| called_three = true; false }
       refute @ex.ignore_mismatched_observation?(@a, @b)
       assert called_one
       assert called_two
@@ -423,9 +423,9 @@ def @ex.enabled?
 
     it "only calls ignore blocks until one matches" do
       called_one = called_two = called_three = false
-      @ex.ignore { |a, b| called_one   = true; false }
-      @ex.ignore { |a, b| called_two   = true; true  }
-      @ex.ignore { |a, b| called_three = true; false }
+      @ex.ignore { |_a, _b| called_one   = true; false }
+      @ex.ignore { |_a, _b| called_two   = true; true  }
+      @ex.ignore { |_a, _b| called_three = true; false }
       assert @ex.ignore_mismatched_observation?(@a, @b)
       assert called_one
       assert called_two

diff --git a/test/scientist/observation_test.rb b/test/scientist/observation_test.rb
@@ -145,7 +145,7 @@
     end
 
     it "doesn't clean nil values" do
-      @experiment.clean { |value| "foo" }
+      @experiment.clean { |_value| "foo" }
       a = Scientist::Observation.new("test", @experiment) { nil }
       assert_nil a.cleaned_value
     end

diff --git a/test/scientist/result_test.rb b/test/scientist/result_test.rb
@@ -80,7 +80,7 @@
     y = Scientist::Observation.new("y", @experiment) { :y }
     z = Scientist::Observation.new("z", @experiment) { :z }
 
-    @experiment.ignore { |control, candidate| candidate == :y }
+    @experiment.ignore { |_control, candidate| candidate == :y }
 
     result = Scientist::Result.new @experiment, [x, y, z], x
 
@@ -105,7 +105,7 @@
     result = Scientist::Result.new @experiment, [a, b], a
     assert_nil result.cohort
 
-    result = Scientist::Result.new @experiment, [a, b], a, ->(res) { "cohort-1" }
+    result = Scientist::Result.new @experiment, [a, b], a, ->(_res) { "cohort-1" }
     assert_equal "cohort-1", result.cohort
   end