Skip to content

don't prepend backtrace or inspect, fix frozen string error #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

don't prepend backtrace or inspect, fix frozen string error #94

wants to merge 1 commit into from

Conversation

ryan-plated
Copy link

I am getting frozen string errors cause of the use of prepend with debug data :/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.091% when pulling 2514787 on plated:fix-frozen-string into 4cc2256 on github:master.

@coveralls
Copy link

coveralls commented Jan 31, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 99.091% when pulling f616c74 on plated:fix-frozen-string into 4cc2256 on github:master.

iamvery
iamvery approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@iamvery iamvery left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I had also opened #96 before seeing this PR. Thank you!

Have you found a workaround in the meantime?

@iamvery iamvery mentioned this pull request Feb 25, 2019
Merged
@ryanong
Copy link

ryanong commented Feb 25, 2019

Monkey patch! The best part of ruby :)

@ryanong
Copy link

ryanong commented Feb 25, 2019

Oh FYI can you merge this for me? I’m away on vacation right now and don’t have access to my work account

@iamvery
Copy link
Contributor

iamvery commented Feb 25, 2019

@ryanong unfortunately i'm not a maintainer. hopefully this will get some attention soon :)

@arthurschreiber arthurschreiber mentioned this pull request Feb 26, 2019
Closed
@ryan-plated ryan-plated changed the title don't prepend backgrace or inspect don't prepend backtrace or inspect, fix frozen string error Mar 6, 2019
@ryan-plated ryan-plated closed this Mar 6, 2019
@ryan-plated ryan-plated deleted the fix-frozen-string branch March 6, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamvery iamvery iamvery approved these changes

@ryanong ryanong ryanong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryan-plated @coveralls @ryanong @iamvery
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy