Skip to content

Allow custom headers and extensions for twirp clients and servers; unify traits; unify error type #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 23, 2025
Merged

Allow custom headers and extensions for twirp clients and servers; unify traits; unify error type #212

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
235de4d
This is actually working
tclem Jul 11, 2025
31bdf95
Clean up
tclem Jul 11, 2025
f425097
Leave some notes
tclem Jul 11, 2025
543f1d3
remove unnecessary traits
aneubeck Jul 14, 2025
925b96b
Client had sync send and that's required
tclem Jul 15, 2025
b25d81a
Experiment with a direct client
tclem Jul 15, 2025
4dfbfdc
Unify error types
tclem Jul 16, 2025
b1930ad
Revive the direct client
tclem Jul 16, 2025
d81670e
Fix readme
tclem Jul 16, 2025
da9a20a
Port over some error helpers
tclem Jul 16, 2025
3e816b3
Remove the direct client experiment
tclem Jul 17, 2025
f4571b5
Cleanup
tclem Jul 17, 2025
8fd41d8
Remove IntoTwirpResponse
tclem Jul 17, 2025
8d8a9ab
Improve error handling
tclem Jul 17, 2025
ee8c300
Leave a note
tclem Jul 17, 2025
f521221
Minor cleanup
tclem Jul 17, 2025
4ca10b3
Use the header const, cleanup
tclem Jul 17, 2025
455bd33
Not sure this is helpful
tclem Jul 17, 2025
067638f
Better docs
tclem Jul 17, 2025
7f29f92
Support for anyhow mapping
tclem Jul 17, 2025
d25bdb2
Merge remote-tracking branch 'origin/main' into tclem/wrap-experiment
tclem Jul 17, 2025
0de631b
temp
tclem Jul 17, 2025
90c237e
Better comment
tclem Jul 18, 2025
a73dba6
Expose this as well
tclem Jul 18, 2025
8113aaf
Don't set retry_after like this
tclem Jul 18, 2025
1b3b22b
0.9.0
tclem Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Leave a note
  • Loading branch information
@tclem
tclem committed Jul 17, 2025
commit ee8c300068ac7c2ea267d92729db14f2232ab069
4 changes: 2 additions & 2 deletions crates/twirp/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ impl From<header::InvalidHeaderValue> for TwirpErrorResponse {
impl IntoResponse for TwirpErrorResponse {
fn into_response(self) -> Response<Body> {
let mut resp = Response::builder()
.status(self.code.http_status_code())
.extension(self.clone())
.status(self.http_status_code())
.extension(self.clone()) // NB: Include the original error in the response extensions so that axum layers can extract (e.g. for logging)
.header(header::CONTENT_TYPE, "application/json");

if let Some(duration) = self.retry_after {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy