Skip to content

issues.list() not working #292

@joecarney

Description

@joecarney
    issues.list({}, function (err, issues) {

is timing out when I use it.


The reason is this... Inside src/github.js, your iterate() _request function..

      var _requestAllPages = Github._requestAllPages = function _requestAllPages(path, cb) {
         var results = [];

         (function iterate() {
            _request('GET', path, null, function (err, res, xhr) {

is returning a xhr value as undefined for me...

As a very quick/dirty test, just to to see if I could get some results back, i added a if (!hxr) {cb} and it started to work fine...

               if (!(res instanceof Array)) {
                  res = [res];
               }

               results.push.apply(results, res);

               if (!xhr) {
                  cb(err, results);
               }

You may want to take a look into this :)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy