Add support for deply key APIs #376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d7f943 to
cd4ffaa
Compare
| /** | ||
| * Get a deploy key for the repository | ||
| * @see https://developer.github.com/v3/repos/keys/#get-a-deploy-key | ||
| * @param {number} id - the id of the webook |
There was a problem hiding this comment.
thanks!
I think {number|string} is better. but I think that "united feeling" will be lost with the fix only here. Because id is also in other places is {number}. For example, getHook.
only here or fix all?
There was a problem hiding this comment.
I would leave it as number, because the objects' ids are numbers in github's API (for most objects).
"owner": {
"login": "octocat",
"id": 1,|
Apart from the two very minor comments, the PR looks good. |
|
For now it was fixed comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add this apis. https://developer.github.com/v3/repos/keys/