Adds missing getCombinedStatus method to Repository.js
#397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like this too. It looks like the PR needs a rebase? |
wking
added a commit
to wking/depviz
that referenced
this pull request
Dec 21, 2016
Using a separate call to the GitHub API [1] for open pull requests, because GitHub doesn't expose this information directly in its issue response. The hack access to _request works around the currently-missing github-tools/github wrapper for this API endpoint [2]. We don't look this up for closed pull requests, because a separate per-issue request is expensive, and users are unlikely to care that much about the CI status of closed pull requests. If it turns out that some do care, we'll have to make the done-ness filter configurable. This commit also shuffles the expanded card from a two-column, three-line layout to a one-column, four-line layout (although the last line is split into a number of columns). That gives us more space for multiple people and longer IDs/titles, keeps the cards at a reasonable size, and doesn't crowd too much. The status icons are: * success: U+2713 (CHECK MARK). * failure: U+26A0 (WARNING SIGN). Also considered: U+2717 (BALLOT X). * pending: U+231B (HOURGLASS). Also considered: * U+25CF (BLACK CIRCLE) * U+2022 (BULLET) * U+23F2 (TIMER CLOCK) [1]: https://developer.github.com/v3/repos/statuses/#get-the-combined-status-for-a-specific-ref [2]: github-tools/github#397
b3ce44c to
7c1f28d
Compare
Current coverage is 90.79% (diff: 100%)@@ master #397 diff @@
==========================================
Files 12 12
Lines 401 402 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 361 365 +4
+ Misses 40 37 -3
Partials 0 0
|
This was referenced Aug 29, 2019
|
Closing in favour of #580. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was about to use this great library I noticed it was missing the exact method I was using it for.
See https://developer.github.com/v3/repos/statuses/#get-the-combined-status-for-a-specific-ref
So thought I better add it for the next person 😸
Changes:
getCombinedStatusto the Repository.js modulegetCombinedStatusmethodLet me know if it needs any changes 👍
Edit:
Added test seems to be passing see:
https://travis-ci.org/michael/github/jobs/175262817#L1148