Skip to content

WIP: Fix linting that is failing the CI #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Repository.js
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,8 @@ class Repository extends Requestable {
* @return {Promise} - the promise for the http request
*/
updatePullRequst(number, options, cb) {
log('Deprecated: This method contains a typo and it has been deprecated. It will be removed in next major version. Use updatePullRequest() instead.');
log('Deprecated: This method contains a typo and it has been deprecated. It will be removed in next major ' +
'version. Use updatePullRequest() instead.');

return this.updatePullRequest(number, options, cb);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"scripts": {
"clean": "gulp clean",
"build": "gulp build",
"test": "mocha --opts ./mocha.opts test/*.spec.js",
"test": "mocha",
"test-verbose": "DEBUG=github* npm test",
"lint": "gulp lint",
"make-docs": "node_modules/.bin/jsdoc -c .jsdoc.json --verbose",
Expand Down
File renamed without changes.
6 changes: 5 additions & 1 deletion test/repository.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import getTestRepoName from './helpers/getTestRepoName';

describe('Repository', function() {
let github;
let remoteRepo;
let user;
let imageB64;
let imageBlob;
Expand All @@ -30,6 +29,8 @@ describe('Repository', function() {
});

describe('reading', function() {
let remoteRepo;

before(function() {
remoteRepo = github.getRepo('michael', 'github');
});
Expand Down Expand Up @@ -265,6 +266,7 @@ describe('Repository', function() {
const releaseBody = 'This is my 49 character long release description.';
let sha;
let releaseId;
let remoteRepo;

before(function() {
user = github.getUser();
Expand Down Expand Up @@ -592,6 +594,8 @@ describe('Repository', function() {
});

describe('deleting', function() {
let remoteRepo;

before(function() {
remoteRepo = github.getRepo(testUser.USERNAME, testRepoName);
});
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy