Skip to content

feature(User): Add List starred gists API #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

knsh14
Copy link
Contributor

@knsh14 knsh14 commented Sep 25, 2017

lib/User.js Outdated
options = {};
}
options.since = this._dateToISO(options.since);
return this._request('GET', "/gists/starred", options, cb);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: switch to single quotes.

@j-rewerts
Copy link
Member

After fixing the lint issue, we can merge this in.

@knsh14
Copy link
Contributor Author

knsh14 commented Apr 8, 2019

thanks for comment!
just fixed your review point.

Copy link
Member

@j-rewerts j-rewerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@j-rewerts
Copy link
Member

@clayreimann Feel free to merge.

@clayreimann clayreimann merged commit cd26446 into github-tools:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy