Skip to content

Fix follow and unfollow user #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2019

Conversation

CodyGramlich
Copy link
Contributor

Fixes issue #553.

@j-rewerts
Copy link
Member

@CodyGramlich Could you write some tests that verify the original problem and show how your changes resolve them?
Nice catch though. Surprised this wasn't reported before.

@CodyGramlich
Copy link
Contributor Author

CodyGramlich commented Apr 24, 2019

@j-rewerts Sure, I'll make a test by requesting to follow a user, and then requesting to get the users that I'm following. Then I'll check if the user I tried to follow is in that list. There isn't really an easier way to test it because the response of following yourself is the same response as if you successfully followed someone else.

@CodyGramlich
Copy link
Contributor Author

@j-rewerts I added some tests. One of them is to try to follow yourself and show that you're not one of your followers. The previous test does the same thing but for a different user and it shows that you are now following the user.

@j-rewerts
Copy link
Member

Sorry for the delay @CodyGramlich. Could you resolve the conflicts?

@j-rewerts
Copy link
Member

Thanks for the extensive tests! I'm trying out a new review process, so bear with me here.

@j-rewerts j-rewerts changed the base branch from master to following-users June 17, 2019 20:22
@j-rewerts j-rewerts merged commit b064242 into github-tools:following-users Jun 17, 2019
@j-rewerts j-rewerts mentioned this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy