Skip to content

Bump version of Axios #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

maluramichael
Copy link
Contributor

Right now i get a github warning because the old version of axios has some major security warnings.

Right now i get a github warning because the old version of axios has some major security warnings.
@kb0rg
Copy link

kb0rg commented Jun 12, 2019

Hi @j-rewerts, do you have an ETA for resolving this? I'm aware of issue #564 (thank you for outlining all that), but am not prepared to switch to Octokit at the moment. In the meantime, I'm very much looking forward to seeing this patch land. Thank you!

@j-rewerts
Copy link
Member

Sorry for the delay! Just trying to get the tests to pass.

@kb0rg
Copy link

kb0rg commented Jun 12, 2019

Thanks! And... no worries at all, I was mainly curious whether you had a timeframe in mind, so I could use that to weigh whether I should be looking into Octokit more seriously. Thank you!

@j-rewerts
Copy link
Member

We've got quite a few tests failing for all of our versions, so it could take some time. I'll follow up in ~4 hours after banging my head on it and get a more solid timeline for this.

@j-rewerts
Copy link
Member

Okay I've got an update on the tests. GitHub has modified their requirements for certain endpoints. Gists now require an account with a confirmed email address, for example. I'll get these tests fixed up and submitted as part of my PR in #567.

@j-rewerts
Copy link
Member

In the interest of averting security issues, I'll merge this in, and fix the tests after (against my better judgement).

@j-rewerts j-rewerts merged commit 8cb6ca3 into github-tools:master Jun 13, 2019
@maluramichael maluramichael deleted the patch-1 branch June 13, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy