Add Spanish translation #25

mirenbz · 2019-09-27T09:30:49Z

I would like to use this course (and others) with my students but they need to be in Spanish, so I translated this one to begin with. I've added the responses files and some options I found in the "Introduction to GitHub" course to the config, but I'm not sure if that's enough or a new language needs to be setup somewhere else.

ghost · 2019-09-27T09:30:52Z

🔴 9 errors found in the config file.

- "preferences[0].options" must be an array
- "preferences[1].type" is required
- "preferences[1].name" is required
- "preferences[1].options" is required
- "preferences[1].value" is not allowed
- "preferences[2].type" is required
- "preferences[2].name" is required
- "preferences[2].options" is required
- "preferences[2].value" is not allowed

github-learning-lab · 2019-09-27T09:30:53Z

🔴 9 errors found in the config file.

- "preferences[0].options" must be an array
- "preferences[1].type" is required
- "preferences[1].name" is required
- "preferences[1].options" is required
- "preferences[1].value" is not allowed
- "preferences[2].type" is required
- "preferences[2].name" is required
- "preferences[2].options" is required
- "preferences[2].value" is not allowed

brianamarie · 2019-09-27T10:11:22Z

This is so exciting, thank you @mberasategi!

@hectorsector, would you have the bandwidth to review this pull request?

mirenbz · 2019-10-02T07:10:46Z

Meanwhile, is it possible to deploy this somewhere so that my students can use it?

(sorry!)

brianamarie · 2019-10-02T11:32:56Z

@hectorsector Can you please assist here?

hectorsector · 2019-10-02T14:03:08Z

Thanks for the translation, @mberasategi and good to see you again! I'm looking into what's going on with the deployment. I don't immediately see anything wrong with the config so it should be working.

If you'd like to publish the course on your own, you can do so by creating it under your own account, or under an organization you own. These docs should help.

arielvalentin · 2019-10-02T15:04:33Z

config.yml

+      es:
+        title: Activa GitHub Pages
+        description: >-
+          Gnera un sitio web con el generador automático de páginas GitHub


Suggested change

Gnera un sitio web con el generador automático de páginas GitHub

Genera un sitio con el generador automático de GitHub Pages

Please be patient with me since I am not sure how to review translations well.

I am not so sure about this translation. The title states Activate GitHub Pages however the description says Generate a website with the automatic generator from GitHub Pages. It's unclear to me if we are activating or generating a site.

Another thing I am not sure about is translating product names. It looks like in one case we refer to the product by its English name and then in the description we translated it? páginas GitHub vs GitHub Pages. Not sure if we want to translate those or not 🤷‍♂

arielvalentin · 2019-10-02T15:08:49Z

config.yml

+    translations:
+      es:
+        title: Personaliza tu página inicial
+        description: Abre un pull request con cambios en la página inicial.


🍺 Interesting. Is our idiom translating here as Open have the same meaning as Abre? I tend to think of these as Starting instead of Opening but I am not sure.

arielvalentin · 2019-10-02T15:10:58Z

config.yml

+    translations:
+      es:
+        title: Combina tu pull request
+        description: Combina el pull request que personaliza tu página inicial.


🍺 ¿Combina? Not sure 🤔

That is what I normally use in my classes, and I think it helps students understand what merge is actually doing. Pro Git translates to fusionar, so that's definitely another option.

Totally understand. I do not usually discuss programming topics with others in Spanish so I have no idea, I would have to ask the community what terms people commonly use.

responses/es/00_class-introduction-issue.md

arielvalentin · 2019-10-02T15:18:10Z

responses/es/00_class-introduction-issue.md

+
+Bienvenida a GitHub Pages y Jekyll :tada:!
+
+Si es la primera vez que usas GitHub Pages o quieres aprender cómo crear y alojar un sitio web con [GitHub Pages](https://pages.github.com), estás en el lugar adecuado. Con GitHub Pages, puedes alojar contenidos como [documentación](https://flight-manual.atom.io/), [currículums](https://github.com/jglovier/resume-template) o cualquier otro contenido estático que quieras. 


🍺 should we have GitHub Pages hyperlinked everywhere in the paragraph?

I didn't look at that, just tried to translate text/links as they are. However I personally think it's enough to link the first instance.

responses/es/07_next-steps.md

responses/es/06_merge-and-celebrate.md

responses/es/05_incorrect-post.md

responses/es/04_create-blog-post.md

mirenbz · 2019-10-03T09:28:20Z

OK @hectorsector ! This does probably not belong here, but how can I enable the "Change course to private" option? I don't want to flood the official Labs with this not-finished-probably-faulty-draft...

mirenbz · 2019-10-03T11:50:46Z

BTW, I plan to translate "Intro to HTML" and "Communicating using Markdown" as well. Just waiting for this to clear, and thus hopefully save us all some review work 😅

brianamarie · 2019-10-15T09:22:54Z

Hi @mberasategi @arielvalentin! I am going to test this myself. I trust the Spanish but I want to make sure the course will function. I'll report back here once I've finished, and either merge, or let you know what is left. 😊 Thank you so much for your work here!

brianamarie

Hello @mberasategi! Thank you for your hard work and patience.

I went through the course (in Spanish and English) and found only this one thing. Once this is updated, this is good to merge! 🎉

responses/es/00_class-introduction-issue.md

Update responses/es/00_class-introduction-issue.md Co-Authored-By: Briana Swift <brianamarie@github.com>

mirenbz · 2019-10-15T09:59:54Z

Done @brianamarie ! Keeps failing the deploy though... 😕

brianamarie · 2019-10-15T10:02:31Z

@mberasategi Thanks! The deploy worked fine when I brought your changes onto a githubtraining branch, so I wonder if that could be the problem. I'll merge, and I'll watch out for the deployment.

brianamarie · 2019-10-15T10:04:50Z

I did need to manually sync the course, but it seems to be working! 🎉 Thank you so much, @mberasategi @arielvalentin!

mberasategi added 2 commits September 27, 2019 11:17

Translate responses

4e9e497

Add language and step translations

453062d

github-learning-lab bot had a problem deploying to production September 27, 2019 09:30 Failure

Correct indentation of language options

bc1bd3a

github-learning-lab bot had a problem deploying to production September 27, 2019 09:32 Failure

brianamarie requested a review from hectorsector September 27, 2019 10:10

Add 'w. Spanish' to title

052be79

github-learning-lab bot had a problem deploying to production October 2, 2019 08:25 Failure

Revert title

8687a89

(sorry!)

github-learning-lab bot had a problem deploying to production October 2, 2019 09:24 Failure

arielvalentin suggested changes Oct 2, 2019

View reviewed changes

mberasategi added 2 commits October 3, 2019 11:47

Add opening exclamation and question marks

e1313d1

Forgot to translate pages

49e34fa

github-learning-lab bot had a problem deploying to production October 3, 2019 09:51 Failure

github-learning-lab bot temporarily deployed to production October 15, 2019 09:24 Inactive

brianamarie mentioned this pull request Oct 15, 2019

Test mberasategi - testing only PR #26

Closed

brianamarie suggested changes Oct 15, 2019

View reviewed changes

responses/es/00_class-introduction-issue.md Outdated Show resolved Hide resolved

Fix italics in parenthesis

1ea315a

Update responses/es/00_class-introduction-issue.md Co-Authored-By: Briana Swift <brianamarie@github.com>

github-learning-lab bot had a problem deploying to production October 15, 2019 09:58 Failure

brianamarie merged commit e3acf5f into githubtraining:master Oct 15, 2019

	Gnera un sitio web con el generador automático de páginas GitHub
	Genera un sitio con el generador automático de GitHub Pages


		Bienvenida a GitHub Pages y Jekyll :tada:!

		Si es la primera vez que usas GitHub Pages o quieres aprender cómo crear y alojar un sitio web con [GitHub Pages](https://pages.github.com), estás en el lugar adecuado. Con GitHub Pages, puedes alojar contenidos como [documentación](https://flight-manual.atom.io/), [currículums](https://github.com/jglovier/resume-template) o cualquier otro contenido estático que quieras.

Add Spanish translation #25

Add Spanish translation #25

Uh oh!

Conversation

mirenbz commented Sep 27, 2019

Uh oh!

ghost commented Sep 27, 2019

🔴 9 errors found in the config file.

Uh oh!

github-learning-lab bot commented Sep 27, 2019

🔴 9 errors found in the config file.

Uh oh!

brianamarie commented Sep 27, 2019

Uh oh!

mirenbz commented Oct 2, 2019

Uh oh!

brianamarie commented Oct 2, 2019

Uh oh!

hectorsector commented Oct 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mirenbz commented Oct 3, 2019

Uh oh!

mirenbz commented Oct 3, 2019

Uh oh!

brianamarie commented Oct 15, 2019

Uh oh!

brianamarie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mirenbz commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianamarie commented Oct 15, 2019

Uh oh!

brianamarie commented Oct 15, 2019

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

mirenbz commented Oct 15, 2019 •

edited

Loading