Tweaking instructions #30
Conversation
Applying a suggestion on a deleted line is not possible.
There was a problem hiding this comment.
@amyschoen thank you for contributing this change! We could consider telling the user what they are linking (since some new users might not be familiar with the URL) --- or leave it as is!
| @@ -12,7 +12,7 @@ You'll also notice that the image tag doesn't need to close since it is consider | |||
|
|
|||
| ### :keyboard: Activity: Add an image to your web page | |||
|
|
|||
| Apply this suggested change, or follow the instructions below if you'd like to type out the code manually. | |||
| Follow the instructions below to add an image. You can use the image suggested below or link to your image of choice. | |||
There was a problem hiding this comment.
| Follow the instructions below to add an image. You can use the image suggested below or link to your image of choice. | |
| Follow the instructions below to add an image. You can use your GitHub avatar image (suggested below) or link to your image of choice. |
|
Not a bad thought @crichID. I stuck with what generically applied to my version locally and the one here. The current release of LL uses profile pic instead of Octocat. |
|
I see your point @crichID, that the more context, the better. But I also see your point @amyschoen that the current instructions are not as universal for other GHES courses. I am personally in favor of the less specific instructions.
This is not actually addressed yet in this pull request. The suggested change code happens in the config. @amyschoen Would there be another way to edit that so the suggested change functions as expected? |
|
Suggestions are new, so I was wondering how that tied in. I was just experiencing the behavior where it had a suggestion that wasn't able to be applied. Should I play around with changing the line number in the config to see if the suggestion could potentially work? I somehow missed uploading the screenshot when I filed this. Here's what it looks like currently:
You can see the |
👍 Yes please, this would be ideal. Thank you! |
|
I'm planning on doing a bunch more testing today. Do you have any documentation you can point me towards that would help? An informal ping on Slack with the info I need will suffice if there's not formal documentation available. |
I pinged you in Slack, but I'll post here too in case anyone else could find this useful: |
|
Thanks for the links @brianamarie. This is way easier to use as a reference than scrolling up in Slack history. |
|
Closing and opening up #35 instead because I deleted my fork too early. |
Applying a suggestion on a deleted line is not possible.
Closes #29
/cc @crichID @brianamarie @hectorsector @JasonEtco