-
Notifications
You must be signed in to change notification settings - Fork 56
Some typos, tweaks, and minor error corrections in ES translation #55
Conversation
Your draft course version was created!You can edit it using the Course Builder UI! |
Awesome, thank you for this, @mberasategi! @davenowell @droidpl would you have bandwidth to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mberasategi - I have requested one change. Thank you for your work!
responses/es/04_commit-something.md
Outdated
|
||
### Recomendaciones para los mensajes de confirmación: | ||
|
||
- No termines tu mensaje con un punto. | ||
- Mantén tu mensaje con 50 o menos caracteres. Si es necesario añade detalles extra en la ventana de descripción extendida. Esta se encuentra justo debajo de la línea de asunto. | ||
- Usa la voz activa. Por ejemplo, "añade" en vez de "añadí" y "une" en vez de "uní" | ||
- Usa la voz activa. Por ejemplo, "añade" en vez de "añadí" y "une" en vez de "uní". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is a good translated example of active vs. passive voice. Here, we want to indicate that the title should focus on what the change does and not who did it. Even if we have to use a few more words to get the point across, I think that's ok.
So here is what I think a more accurate Spanish example might be:
"Añade la funcionalidad" en vez de "La funcionalidad se añadió" o "La funcionalidad fue añadido".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I didn't even consider this. Will change to:
- Usa la voz activa. Por ejemplo, "Añade la funcionalidad xx" en vez de "Añadida la funcionalidad xx" y "Combina los cambios" en lugar de "Combinados los cambios".
BTW @davenowell , here's where we have the |
@mberasategi If you could refer to http://docs.github.com/es and use whichever word appears there, that would be fine. I think the word "propuesta" is used. |
Alright, Docs says "propuesta". I've went through replacing all "propuesta"s with "incidencia" in Communicating using Markdown... 🤦🏼 I guess those should be replaced back then! |
No description provided.