Prepare course for release #3

mattdavis0351 · 2020-03-24T23:30:30Z

This PR addresses the release checklist for this course. The current progress can be found in the tracking issue.

github-learning-lab · 2020-03-24T23:30:43Z

Your draft course version was created!

You can edit it using the Course Builder UI!

github-learning-lab · 2020-03-25T21:06:38Z

🔴 16 errors found in the config file.

- Action [2] in [GitHub Actions: Using GitHub Script] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[0].link" does not match any of the allowed types
- Action [5] in [Setup a workflow file] does not match the `createReview` action's schema
  - "store" is not allowed
- "steps[1].link" does not match any of the allowed types
- Action [triggerIssue] in [Merge the new workflow into the master branch] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[2].link" does not match any of the allowed types
- "steps[3].link" does not match any of the allowed types
- Action [5] in [Modify your workflow file] does not match the `createReview` action's schema
  - "store" is not allowed
- "steps[4].link" does not match any of the allowed types
- Action [triggerIssue] in [Merge the new workflow into the master branch] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[5].link" does not match any of the allowed types

github-learning-lab · 2020-03-25T21:13:34Z

🔴 16 errors found in the config file.

- Action [2] in [GitHub Actions: Using GitHub Script] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[0].link" does not match any of the allowed types
- Action [5] in [Setup a workflow file] does not match the `createReview` action's schema
  - "store" is not allowed
- "steps[1].link" does not match any of the allowed types
- Action [triggerIssue] in [Merge the new workflow into the master branch] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[2].link" does not match any of the allowed types
- "steps[3].link" does not match any of the allowed types
- Action [5] in [Modify your workflow file] does not match the `createReview` action's schema
  - "store" is not allowed
- "steps[4].link" does not match any of the allowed types
- Action [triggerIssue] in [Merge the new workflow into the master branch] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[5].link" does not match any of the allowed types

github-learning-lab · 2020-03-25T21:16:28Z

🔴 16 errors found in the config file.

- Action [2] in [GitHub Actions: Using GitHub Script] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[0].link" does not match any of the allowed types
- Action [5] in [Setup a workflow file] does not match the `createReview` action's schema
  - "store" is not allowed
- "steps[1].link" does not match any of the allowed types
- Action [triggerIssue] in [Merge the new workflow into the master branch] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[2].link" does not match any of the allowed types
- "steps[3].link" does not match any of the allowed types
- Action [5] in [Modify your workflow file] does not match the `createReview` action's schema
  - "store" is not allowed
- "steps[4].link" does not match any of the allowed types
- Action [triggerIssue] in [Merge the new workflow into the master branch] does not match the `createIssue` action's schema
  - "store" is not allowed
- "steps[5].link" does not match any of the allowed types

github-learning-lab · 2020-03-25T23:45:38Z

🔴 1 errors found in the config file.

- "steps[5].link" does not match any of the allowed types

github-learning-lab · 2020-03-25T23:47:17Z

🔴 1 errors found in the config file.

- "steps[5].link" does not match any of the allowed types

…e-github-script into release-prep

brianamarie · 2020-03-31T11:27:42Z

I'm going through this course for the 2nd time with an eye on the flow with the bot activating the triggers for the actions. It didn't stand out to me before, but I do think there's a chance to reduce confusion here. If I'm understanding correctly, I see the pros/cons as:

The bot opening the issue

👍One less step for the learner to complete
👍All learner actions are about writing code
👎We are assuming that the learner can differentiate between bot activity and action-triggered activity (This is a big one to me - there is a lot of mystery behind Learning Lab, and I think it's a risk to let users confuse the Learning Lab things and the Action things. We can't validate their understanding any other way.)

The Learner opening the issue

👍Learner has to mentally connect the dots that the action is triggered by them opening an issue, or commenting, or whatever was specified in the workflow

I don't see the learner opening issues as a practice in opening issues for no reason - I see it as solidifying the understanding of the workflow that we've asked them to build.

All that said, it didn't occur to me when I went through the course for the first time. Just my two cents 💰

mattdavis0351 · 2020-03-31T19:28:29Z

@brianamarie imagine a real world project. I set up the workflow for that repo, and that workflow responds to issues when they are opened by the community. Once I did that I would have to wait for people to open issues themselves, aside from the ones that I may or may not open to track things.

By having the bot open the issue, I feel as though it simulates a more accurate representation of this workflow in the wild. The bot essentially becomes a community member that has stumbled on your repo and opened an issue for whatever reason.

I worry that if the learner is the one who triggers this workflow then we lose that simulation. We could also run the risk of the learner assuming this workflow is tied to them opening issues, and not anyone in the world. That risk is small, but if I'm super new to GitHub and collaboration this is a potential misconception.

Taking the simulated aspect into account, does that change your feedback in anyway?

brianamarie · 2020-04-01T10:18:25Z

@mattdavis0351 I completely see what you mean. My reasoning is that while simulating the environment is important, it may lose value as a training exercise if it's so realistic that we sacrifice the scaffolding that creates a positive learning experience.

As a possible compromise, what if we had the user trigger the first several instances to solidify the knowledge, then show it as another collaborator later in the course?

hectorsector · 2020-04-03T01:19:45Z

@mattdavis0351 I added some validations that I think will help!

hectorsector

@mattdavis0351 once we merge this branch I'll get our team testing. We can open new PRs so it isn't the end!

hectorsector · 2020-04-07T12:41:20Z

@mattdavis0351 based on our conversations over Slack, I'm going to merge this so I can get this course QA'd.

Create LICENSE

cd38341

github-learning-lab bot deployed to production March 24, 2020 23:30 View deployment

mattdavis0351 closed this Mar 24, 2020

mattdavis0351 reopened this Mar 24, 2020

github-learning-lab bot deployed to production March 24, 2020 23:47 View deployment

Merge branch 'master' into release-prep

d4b40ed

github-learning-lab bot deployed to production March 24, 2020 23:47 View deployment

update course-details.md

a4e950c

github-learning-lab bot deployed to production March 24, 2020 23:57 View deployment

store test

9afb6f0

github-learning-lab bot had a problem deploying to production March 25, 2020 21:06 Failure

store test

c9cb46d

github-learning-lab bot had a problem deploying to production March 25, 2020 21:13 Failure

store test

189aba9

github-learning-lab bot had a problem deploying to production March 25, 2020 21:16 Failure

checking store

6b61ae7

github-learning-lab bot had a problem deploying to production March 25, 2020 23:45 Failure

typo fix

ee35913

github-learning-lab bot had a problem deploying to production March 25, 2020 23:47 Failure

typo fix

0b2e0f0

github-learning-lab bot deployed to production March 25, 2020 23:48 View deployment

remove store in before

b073086

github-learning-lab bot deployed to production March 26, 2020 00:01 View deployment

add reslut.data back

a9b78c4

github-learning-lab bot deployed to production March 30, 2020 16:09 View deployment

mattdavis0351 added 2 commits March 30, 2020 10:37

use store instead of action_id

413f99e

Merge branch 'release-prep' of https://github.com/githubtraining/writ…

a34153e

…e-github-script into release-prep

github-learning-lab bot deployed to production March 30, 2020 17:38 View deployment

remove old action_id references, store works here

947f38b

github-learning-lab bot deployed to production March 30, 2020 17:47 View deployment

use better pull naming

45536e7

github-learning-lab bot deployed to production March 30, 2020 22:04 View deployment

hectorsector added 6 commits April 2, 2020 19:41

add a tag

6518b31

clean up the first step a bit

7ad5054

validate learner's merging first PR

837455e

clean up second step a bit

4b4b15c

s/registration.store/store

ec26229

add remaining validations

c719dcc

github-learning-lab bot deployed to production April 3, 2020 01:09 View deployment

hectorsector added 3 commits April 2, 2020 21:12

typo for pullUrl

7be42b4

fix typo on issue link

ead9d07

use the store for the actions link

fe4ea22

github-learning-lab bot deployed to production April 3, 2020 01:19 View deployment

hectorsector approved these changes Apr 6, 2020

View reviewed changes

add image of working issue

f480832

github-learning-lab bot deployed to production April 7, 2020 12:40 View deployment

hectorsector merged commit 3396a67 into master Apr 7, 2020

hectorsector deleted the release-prep branch April 7, 2020 12:41

lmkeston mentioned this pull request Apr 8, 2020

Help learner when workflows don't run #6

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prepare course for release #3

Prepare course for release #3

Uh oh!

mattdavis0351 commented Mar 24, 2020

Uh oh!

github-learning-lab bot commented Mar 24, 2020

Uh oh!

github-learning-lab bot commented Mar 25, 2020

Uh oh!

github-learning-lab bot commented Mar 25, 2020

Uh oh!

github-learning-lab bot commented Mar 25, 2020

Uh oh!

github-learning-lab bot commented Mar 25, 2020

Uh oh!

github-learning-lab bot commented Mar 25, 2020

Uh oh!

brianamarie commented Mar 31, 2020

Uh oh!

mattdavis0351 commented Mar 31, 2020

Uh oh!

brianamarie commented Apr 1, 2020

Uh oh!

hectorsector commented Apr 3, 2020

Uh oh!

hectorsector left a comment

Uh oh!

hectorsector commented Apr 7, 2020

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Prepare course for release #3

Prepare course for release #3

Uh oh!

Conversation

mattdavis0351 commented Mar 24, 2020

Uh oh!

github-learning-lab bot commented Mar 24, 2020

Your draft course version was created!

Uh oh!

github-learning-lab bot commented Mar 25, 2020

🔴 16 errors found in the config file.

Uh oh!

github-learning-lab bot commented Mar 25, 2020

🔴 16 errors found in the config file.

Uh oh!

github-learning-lab bot commented Mar 25, 2020

🔴 16 errors found in the config file.

Uh oh!

github-learning-lab bot commented Mar 25, 2020

🔴 1 errors found in the config file.

Uh oh!

github-learning-lab bot commented Mar 25, 2020

🔴 1 errors found in the config file.

Uh oh!

brianamarie commented Mar 31, 2020

The bot opening the issue

The Learner opening the issue

Uh oh!

mattdavis0351 commented Mar 31, 2020

Uh oh!

brianamarie commented Apr 1, 2020

Uh oh!

hectorsector commented Apr 3, 2020

Uh oh!

hectorsector left a comment

Choose a reason for hiding this comment

Uh oh!

hectorsector commented Apr 7, 2020

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.