Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Help learner when workflows don't run #6

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Conversation

hectorsector
Copy link
Member

This PR adds some troubleshooting steps for the learner in case there are problems with their workflow.

@github-learning-lab
Copy link

Your draft course version was created!


You can edit it using the Course Builder UI!

@github-learning-lab
Copy link

This pull request will create a new major version of your course; changes to the title and other metadata will only apply to the course once the pull request is merged!

@hectorsector hectorsector requested a review from lmkeston April 7, 2020 18:24
Copy link

@lmkeston lmkeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectorsector I would suggest adding another line to the troubleshooting. I had to add another issue to trigger the workflow after i fixed my code. I'm not sure the learner would realize that.

@hectorsector
Copy link
Member Author

I had to add another issue to trigger the workflow after i fixed my code

I'm not sure I understand this one, can you elaborate @lmkeston?

@lmkeston
Copy link

lmkeston commented Apr 8, 2020

I had to add another issue to trigger the workflow after i fixed my code

I'm not sure I understand this one, can you elaborate @lmkeston?

@hectorsector here are the steps I followed:

  • I added my workflow for the first steps in the course with a deliberate typo, then merged the PR.
  • the bot then opens Issue Prepare course for release #3, "Create an issue comment with GitHub Script". Opening this issue is supposed to trigger the workflow, but mine fails due to the typo.
  • I then followed the troubleshooting steps you added to correct the code, remove branch protection, and merge in the changes.
  • however the workflow still doesn't run because it is triggered by the opening of an issue. so i had to create another issue, which in turn kicked off the workflow, and the bot then responded back in Issue Prepare course for release #3, "Create an issue comment with GitHub Script".

Does that make sense?

Try the following troubleshooting steps:
1. Click on the [Actions tab]({{ store.actionsUrl }}) to see the status of your workflow run. See [Managing a workflow run](https://help.github.com/en/actions/configuring-and-managing-workflows/managing-a-workflow-run) on GitHub Help for more information.
1. Edit your [workflow file]( {{ store.workflowEditUrl }}) and look for errors in the linter built into the browser.
1. Look for the [workflow trigger](https://help.github.com/en/actions/reference/events-that-trigger-workflows) and ensure you are performing an action that triggers that workflow.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however the workflow still doesn't run because it is triggered by the opening of an issue. so i had to create another issue

It makes sense now, thank you @lmkeston! Does this troubleshooting step not capture that?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does, but i'm not sure learners would realize that the issue that was just added won't trigger it after fixing the code, that a new issue is required to unblock. your call @hectorsector!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @mattdavis0351?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectorsector it seems as though it captures it in the instructions, and both of you agree on that. Let's run it like this to do some testing. If we see this come up often in the forum, then we can adjust the wording.

I'd hate to let a hypothetical understanding of instructions derail shipping this. Let' ship to learn 🤷‍♂️

Copy link
Contributor

@brianamarie brianamarie Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Unsolicited feedback from me, let's ship to learn!

PS none of my gifs are working so here's a link to the one I'm trying to post: https://media.giphy.com/media/l09y7RIxj7X12S24gN/giphy.gif

@hectorsector hectorsector merged commit bbf6866 into master Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy