Skip to content

Fix git push hanging when stdout/stderr is big #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2014
Merged

Fix git push hanging when stdout/stderr is big #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions git/db/cmd/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,11 @@ def get_push_info(repo, remotename_or_url, proc, progress):
# we hope stdout can hold all the data, it should ...
# read the lines manually as it will use carriage returns between the messages
# to override the previous one. This is why we read the bytes manually
digest_process_messages(proc.stderr, progress)
stdout, stderr = proc.communicate()
digest_process_messages(StringIO(stderr), progress)

output = IterableList('name')
for line in proc.stdout.readlines():
for line in stdout.splitlines():
try:
output.append(CmdPushInfo._from_line(repo, remotename_or_url, line))
except ValueError:
Expand All @@ -139,7 +140,6 @@ def get_push_info(repo, remotename_or_url, proc, progress):
# END exception handling
# END for each line

finalize_process(proc)
return output


Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy