Skip to content

Conversation

znerol
Copy link

@znerol znerol commented Oct 18, 2012

Strip the last line of the output if it is empty (default). Stripping should be disabled whenever it is important that the output is not modified in any way. For example when retrieving patch files using git-diff.

Strip the last line of the output if it is empty (default). Stripping should be
disabled whenever it is important that the output is not modified in any way.
For example when retrieving patch files using git-diff.
@Byron
Copy link
Member

Byron commented Oct 21, 2012

Thanks for the fix.
One last question though - are you sure you want it to be in master ? After all, master is still experimental, and the only version I would endorse for production purposes is 0.3 (in the respective branch).

Byron added a commit that referenced this pull request Oct 21, 2012
Add an output_strip kwarg to Git.execute
@Byron Byron merged commit 0e90a8f into gitpython-developers:master Oct 21, 2012
@znerol
Copy link
Author

znerol commented Oct 21, 2012

It certainly would be nice to have that in 0.3. You should be able to git cherry-pick 0e90a8f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy