You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a failing test due to changed matplotlib.cm API and various deprecation warnings.
The external.echo warning filter is a bit problematic in that it depends on glue.viewers being tested after glue.plugins if at all, otherwise (if glue.external.echo has not been already imported) glue/viewers/histogram/qt/tests/test_data_viewer.py::TestHistogramViewer::test_session_back_compat[1]
will raise a warning as well.
The last commit replaces deprecated matplotlib canvas.*_event centrally in viewers/matplotlib/qt/widget as a quicker (and dirtier?) fix to changing all calls in the tests individually; may need discussion. The reasons for the upstream change are discussed in matplotlib/matplotlib#16931.
Might consider using more exact copies of the versions in matplotlib.backend_bases, but as they are only used in the tests, those should suffice.
There's 24 calls in 3 test files in total; could perhaps be changed in place once we drop mpl < 3.6.
I've added lts envs with matplotlib 3.5.* to isolate the errors in the py310 jobs; otherwise no idea what more to make of the 6 recurring negative xerr "Exceptions caught in Qt event loop" for each test...
While it's failing here for Linux and macOS, but not Windows, the same tests all pass with mpl 3.6.0 for both my Mac systems, arm64 and x86_64 alike.
Can only speculate that some of the NaN magic in matplotlib/matplotlib#22929 broke this, but probably not at the Python level.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing a failing test due to changed
matplotlib.cmAPI and various deprecation warnings.The
external.echowarning filter is a bit problematic in that it depends onglue.viewersbeing tested afterglue.pluginsif at all, otherwise (ifglue.external.echohas not been already imported)glue/viewers/histogram/qt/tests/test_data_viewer.py::TestHistogramViewer::test_session_back_compat[1]will raise a warning as well.
The last commit replaces deprecated matplotlib
canvas.*_eventcentrally inviewers/matplotlib/qt/widgetas a quicker (and dirtier?) fix to changing all calls in the tests individually; may need discussion. The reasons for the upstream change are discussed in matplotlib/matplotlib#16931.