lint: update floatCompare checker #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
previously approved these changes
Aug 4, 2018
lint/floatCompare_checker.go
Outdated
| return astp.IsBinaryExpr(exprx) || astp.IsBinaryExpr(expry) | ||
| } | ||
|
|
||
| func identExpr(x ast.Node, y ast.Node) (ast.Expr, *ast.BinaryExpr, bool) { |
There was a problem hiding this comment.
It will be better to make it as a floatCompareChecker method.
There was a problem hiding this comment.
And it might be a identExpr(x, y ast.Node) ;D
lint/floatCompare_checker.go
Outdated
| @@ -30,20 +34,66 @@ func (c *floatCompareChecker) VisitLocalExpr(expr ast.Expr) { | |||
| return | |||
| } | |||
| if binexpr.Op == token.EQL || binexpr.Op == token.NEQ { | |||
| typx, ok := c.ctx.typesInfo.TypeOf(binexpr.X).(*types.Basic) | |||
| if ok && typx.Info()&types.IsFloat != 0 { | |||
| if c.isFloatExpr(binexpr) && c.isMultiBinaryExpr(binexpr) && | |||
There was a problem hiding this comment.
Stylish: expressions can be splitted by lines 😉
| func (c *floatCompareChecker) warn(expr *ast.BinaryExpr) { | ||
| var op string | ||
| op := ">=" |
There was a problem hiding this comment.
So...we do not support <=, am I right?
1. Fix print 'binaryExpr' as second argument 2. Add detection NaNCheckExpr: 'x != x' and InfCheckExpr: 'x + x == x'. Result: less false-positives.
…com/go-critic/go-critic into ludweeg/update_floatCompare_checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result: less false-positives.