refactor transport: plumbing: packp, refactor types (1/5) #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e7a3c8 to
3248748
Compare
3248748 to
3e2ba6a
Compare
3e2ba6a to
fecc06e
Compare
pjbgf
reviewed
Jan 1, 2025
This change makes packp types follow the git protocol and simplifies the implementation of `Encode` and `Decode` methods to be consistent with the rest of the types. Reference: https://git-scm.com/docs/gitprotocol-pack Update plumbing/protocol/packp/advrefs.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> Update plumbing/protocol/packp/uphav.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
This type is used to represent HTTP smart protocol service payload request and response.
2b293b9 to
9986c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes packp types follow the git protocol and simplifies the implementation of
EncodeandDecodemethods to be consistent with the rest of the types.Reference: https://git-scm.com/docs/gitprotocol-pack
This extracts changes from #1111
TODO:
transportrefactor transport: plumbing: transport, refactor and define transport operations (2/5) #1337multi_acksupport based on refactor transport: plumbing: transport, support multi-ack and multi-ack-detailed capabilities (3/5) #1338This needs #1299 and #1300
Supersedes: #938
Supersedes: #1111