Skip to content

Support relative paths in PlainInit/PlainClone. fixes #1610 #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+11 −0
Closed

Support relative paths in PlainInit/PlainClone. fixes #1610 #1611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf23ed
Support relative paths in PlainInit/PlainClone. fixes #1610
Jul 21, 2025
fecaeff
better error handling
Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,17 @@ func PlainInit(path string, isBare bool, options ...InitOption) (*Repository, er
return Init(s, options...)
}
} else {
// Allow users to use relative paths. Convert them
Copy link
Member

@pjbgf pjbgf Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only handling the non bare clones. Please move the logic above the if isBare {.

Instead of the comment, we could just add a // go-git/go-git#1610

// to absolute paths to avoid osfs pre-pending
// its baseDir and wreaking havoc by doubling
// up the baseDir prefix.
if !filepath.IsAbs(path) {
var err error
path, err = filepath.Abs(path)
if err != nil {
return nil, fmt.Errorf("PlainInit path error: filepath.Abs('%v') error: '%v'", path, err)
}
}
wt = osfs.New(path, osfs.WithBoundOS())
dot, _ = wt.Chroot(GitDirName)
initFn = func(s *filesystem.Storage) (*Repository, error) {
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy