Print qualified type name when ErrorUnused=true causes errors for unused keys in embedded fields #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed keys in embedded fields
mx-psi
approved these changes
Jul 1, 2025
|
@jmacd could you please rebase and fix the lint violation? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids showing an empty-string in an error message which can be quite vexing. The underlying issue which led to this error message was the presence of a ErrorUnused=true with an embedded, squashed struct. This issue is discussed elsewhere, maybe:
#81
#89
This addresses the mystery as discussed in open-telemetry/opentelemetry-collector#13273.