Gold tests for utils #1004
Open
Gold tests for utils #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v19 compatibility This commit introduces a test suite for the utility modules located in the `examples/utils/` directory. Key changes: - Created a new test directory: `examples/utils/tests/`. - Added `examples/utils/tests/__init__.py`. - Added `examples/utils/tests/test_example_helpers.py` with unit tests for `get_printable_datetime` and `get_image_bytes_from_url` using the `unittest` framework and `unittest.mock`. - Verified that the existing `google-ads` client library (v26.1.0) already supports Google Ads API v19, so no direct dependency changes for API versioning were required. - Updated `noxfile.py`: Modified the `TEST_COMMAND` for `unittest discover` to scan from the project root (`-s .`) instead of just the top-level `tests` directory. This ensures the new tests in `examples/utils/tests/` are discovered and executed by the standard `nox` testing sessions. - Adjusted the import statement in `test_example_helpers.py` to `from examples.utils import example_helpers` to ensure correct module resolution when tests are run from the project root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…v19 compatibility
This commit introduces a test suite for the utility modules located in the
examples/utils/directory.Key changes:
examples/utils/tests/.examples/utils/tests/__init__.py.examples/utils/tests/test_example_helpers.pywith unit tests forget_printable_datetimeandget_image_bytes_from_urlusing theunittestframework andunittest.mock.google-adsclient library (v26.1.0) already supports Google Ads API v19, so no direct dependency changes for API versioning were required.noxfile.py: Modified theTEST_COMMANDforunittest discoverto scan from the project root (-s .) instead of just the top-leveltestsdirectory. This ensures the new tests inexamples/utils/tests/are discovered and executed by the standardnoxtesting sessions.test_example_helpers.pytofrom examples.utils import example_helpersto ensure correct module resolution when tests are run from the project root.