Skip to content

Added type hints to google/ads/googleads #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobhancockg
Copy link
Contributor

…iles:

This change introduces Python type hints and annotations to the following files:

  • google/ads/googleads/client.py
  • google/ads/googleads/config.py
  • google/ads/googleads/errors.py
  • google/ads/googleads/oauth2.py
  • google/ads/googleads/util.py

Type hints improve code readability and help with static analysis. I used typing.Any and # type: ignore where necessary to handle dynamic typing or external library interactions. No changes were needed for google/ads/googleads/__init__.py as it only contains imports and a version string.

…iles:

This change introduces Python type hints and annotations to the following files:
- google/ads/googleads/client.py
- google/ads/googleads/config.py
- google/ads/googleads/errors.py
- google/ads/googleads/oauth2.py
- google/ads/googleads/util.py

Type hints improve code readability and help with static analysis. I used `typing.Any` and `# type: ignore` where necessary to handle dynamic typing or external library interactions. No changes were needed for `google/ads/googleads/__init__.py` as it only contains imports and a version string.
@bobhancockg bobhancockg requested a review from a team as a code owner May 24, 2025 14:27
@bobhancockg bobhancockg changed the title Here's how I've added type annotations to your google/ads/googleads f… Added type annotations to your google/ads/googlead Jun 2, 2025
@bobhancockg bobhancockg changed the title Added type annotations to your google/ads/googlead Added type hints to google/ads/googleads Jun 2, 2025
@BenRKarl BenRKarl added the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@kokoro-team kokoro-team removed the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@BenRKarl BenRKarl added the kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy