Skip to content

Gold tests for campaign management #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobhancockg
Copy link
Contributor

This commit introduces a test suite for the Python files in your examples/campaign_management directory.

Here's what I did:

  • Created a new subdirectory named examples/campaign_management/tests.
  • Added an init.py file to this new directory.
  • Created individual test files for each of your example scripts:
    • test_add_campaign_labels.py
    • test_add_complete_campaigns_using_batch_job.py
    • test_create_experiment.py
    • test_get_all_disapproved_ads.py
    • test_set_ad_parameters.py
    • test_update_campaign_criterion_bid_modifier.py
    • test_validate_ad.py
  • Each test file includes a basic test structure with a smoke test that mocks the GoogleAdsClient and the main function of the example.
  • I also added comments to ensure tests will be written to use Google Ads API v19.

This commit introduces a test suite for the Python files in your examples/campaign_management directory.

Here's what I did:
- Created a new subdirectory named examples/campaign_management/tests.
- Added an __init__.py file to this new directory.
- Created individual test files for each of your example scripts:
    - test_add_campaign_labels.py
    - test_add_complete_campaigns_using_batch_job.py
    - test_create_experiment.py
    - test_get_all_disapproved_ads.py
    - test_set_ad_parameters.py
    - test_update_campaign_criterion_bid_modifier.py
    - test_validate_ad.py
- Each test file includes a basic test structure with a smoke test that mocks the GoogleAdsClient and the main function of the example.
- I also added comments to ensure tests will be written to use Google Ads API v19.
@bobhancockg bobhancockg requested a review from a team as a code owner May 31, 2025 18:55
@bobhancockg bobhancockg requested review from AnashOommen and sundquist and removed request for AnashOommen and sundquist May 31, 2025 18:55
@bobhancockg bobhancockg changed the title Gold I've added a test suite for the campaign management examples. Gold tests for the campaign management examples. Jun 2, 2025
@bobhancockg bobhancockg changed the title Gold tests for the campaign management examples. Gold tests for campaign management Jun 2, 2025
@BenRKarl BenRKarl added the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@kokoro-team kokoro-team removed the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@BenRKarl BenRKarl added the kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy