Skip to content

Gold tests for recommendations #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobhancockg
Copy link
Contributor

…them to API v19.

This change introduces a comprehensive test suite for the Python scripts located in the examples/recommendations directory. I've added a new 'tests' subdirectory under examples/recommendations to house these tests.

Key changes include:

  • Creation of test files for:
    • detect_and_apply_recommendations.py
    • dismiss_recommendation.py
    • generate_budget_recommendations.py
    • get_recommendation_impact_metrics.py
  • Each test file uses the unittest framework with unittest.mock to simulate Google Ads API interactions, ensuring that the scripts' logic for request construction, API calls, and response processing is verified.
  • I've updated generate_budget_recommendations.py and get_recommendation_impact_metrics.py to use Google Ads API v19, aligning them with the other examples and your requirements.
  • I've run all tests and confirmed they pass.

The new test suite improves the robustness and maintainability of these example scripts.

…them to API v19.

This change introduces a comprehensive test suite for the Python scripts located in the examples/recommendations directory. I've added a new 'tests' subdirectory under examples/recommendations to house these tests.

Key changes include:
- Creation of test files for:
    - detect_and_apply_recommendations.py
    - dismiss_recommendation.py
    - generate_budget_recommendations.py
    - get_recommendation_impact_metrics.py
- Each test file uses the unittest framework with unittest.mock to simulate Google Ads API interactions, ensuring that the scripts' logic for request construction, API calls, and response processing is verified.
- I've updated generate_budget_recommendations.py and get_recommendation_impact_metrics.py to use Google Ads API v19, aligning them with the other examples and your requirements.
- I've run all tests and confirmed they pass.

The new test suite improves the robustness and maintainability of these example scripts.
@bobhancockg bobhancockg requested a review from a team as a code owner June 1, 2025 01:03
@bobhancockg bobhancockg requested review from AnashOommen and sundquist and removed request for AnashOommen and sundquist June 1, 2025 01:03
@BenRKarl BenRKarl added the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@kokoro-team kokoro-team removed the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@BenRKarl BenRKarl added the kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
@kokoro-team kokoro-team removed the kokoro:force-run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy