feat: Add null_markers property to LoadJobConfig and CSVOptions #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Jul 15, 2025
| @@ -42,6 +42,7 @@ def _setUpConstants(self): | |||
| self.TIME_ZONE = "UTC" | |||
| self.TIME_FORMAT = "%H:%M:%S" | |||
| self.TIMESTAMP_FORMAT = "YYYY-MM-DD HH:MM:SS.SSSSSSZ" | |||
| self.NULL_MARKERS = ["", "NA"] | |||
There was a problem hiding this comment.
Nit (more of an FYI than a blocker): I really dislike the pattern of hiding test data in the setup methods, but since this is the existing convention, we should probably wait to clean that up in a separate PR.
tests should never rely on default values that are specified by a helper method
See https://testing.googleblog.com/2018/02/testing-on-toilet-cleanly-create-test.html
This was referenced Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new configuration options for BigQuery load jobs and external table definitions, aligning with recent updates to the underlying protos.
New option(s) added:
null_markers: Represents a sequence of null values. (Applies toLoadJobConfig,LoadJob, andExternalConfig)Changes include:
Added corresponding properties (getters/setters) to
LoadJobConfig,LoadJob, andExternalConfig.Updated docstrings and type hints for all new attributes.
Updated unit tests to cover the new options, ensuring they are correctly handled during object initialization, serialization to API representation, and deserialization from API responses.
Fixes: #830