Skip to content

feat: add st_buffer, st_centroid, and st_convexhull and their corresponding GeoSeries methods #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: add st_buffer, st_centroid, and st_convexhull and their corresponding GeoSeries methods #1963

wants to merge 25 commits into from
+996 −60

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 5, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 5, 2025
tswast
tswast commented Aug 5, 2025
View reviewed changes
bigframes/geopandas/geoseries.py Outdated
Comment on lines 95 to 96
def buffer(self: GeoSeries, distance: float) -> bigframes.series.Series: # type: ignore
return self._apply_unary_op(ops.GeoStBufferOp(distance=distance))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should raise NotImplementedError because in BigQuery, distance is in meters.

tswast
tswast commented Aug 5, 2025
View reviewed changes
@tswast tswast mentioned this pull request Aug 5, 2025
Open
1 task
@tswast tswast marked this pull request as ready for review August 5, 2025 18:35
@tswast tswast requested review from a team as code owners August 5, 2025 18:35
@tswast tswast requested a review from GarrettWu August 5, 2025 18:35
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 6, 2025
@tswast
Copy link
Collaborator Author

tswast commented Aug 6, 2025

@GarrettWu I got the mypy checks passing and verified the system tests pass locally. I think this is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

At least 1 approving review is required to merge this pull request.

Assignees

@ericfe-google ericfe-google

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @ericfe-google
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy