Skip to content

feat: support Series.dot on a DataFrame input #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: support Series.dot on a DataFrame input #230

wants to merge 15 commits into from
+119 −4

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 23, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 312559139 🦕

@shobsi shobsi requested review from a team as code owners November 23, 2023 02:11
@shobsi shobsi requested a review from Genesis929 November 23, 2023 02:11
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 23, 2023
Genesis929
Genesis929 previously approved these changes Nov 27, 2023
View reviewed changes
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 27, 2023
TrevorBergeron
TrevorBergeron requested changes Nov 28, 2023
View reviewed changes
bigframes/series.py Outdated
Comment on lines 684 to 691
return Series(
[
pandas.NA if other[col].isna().any() else (self * other[col]).sum()
for col in other.columns
],
index=other.columns,
name=self.name,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will perform several queries, as each aggregate .any() operation initiates a query. I think we can do this more efficiently.

Copy link
Contributor Author

@shobsi shobsi Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent an optimization, PTAL. It doesn't apply to multi-index yet due to b/313747368, left a TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron requested changes

@Genesis929 Genesis929 Genesis929 left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @TrevorBergeron @Genesis929
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy