test: enable emulator tests for POSTGRESQL dialect #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -525,7 +525,9 @@ def reload(self): | |||
| self._encryption_config = response.encryption_config | |||
| self._encryption_info = response.encryption_info | |||
| self._default_leader = response.default_leader | |||
| self._database_dialect = response.database_dialect | |||
| # Only update if the data is specific to avoid losing specificity. | |||
| if response.database_dialect != DatabaseDialect.DATABASE_DIALECT_UNSPECIFIED: | |||
There was a problem hiding this comment.
Will there be such a situation where backend returns UNSPECIFIED dialect?
AFAIK, the default dialect is GOOGLE_SQL. Correct me if I am missing something
There was a problem hiding this comment.
This is an issue when working with the emulator. It is returning DATABASE_DIALECT_UNSPECIFIED which is overriding the dialect that this object already had. This shouldn't be an issue in production.
harshachinta
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables emulator testing in POSTGRESQL dialect for system tests to improve test coverage.