chore: Add Custom OpenTelemetry Exporter in for Service Metrics #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1c9e4b8 to
606f76f
Compare
606f76f to
2e0acea
Compare
rahul2393
requested changes
Jan 2, 2025
rahul2393
approved these changes
Jan 3, 2025
aakashanandg
pushed a commit
to aakashanandg/python-spanner
that referenced
this pull request
Jan 8, 2025
…leapis#1273) * chore: Add Custom OpenTelemetry Exporter in for Service Metrics * Updated copyright dates to 2025 --------- Co-authored-by: rahul2393 <irahul@google.com>
olavloite
added a commit
that referenced
this pull request
Jan 9, 2025
…actions (#1279) * fix: update retry strategy for mutation calls to handle aborted transactions * test: add mock server test for aborted batch * chore(python): Update the python version in docs presubmit to use 3.10 (#1281) Source-Link: googleapis/synthtool@de3def6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * fix:Refactoring existing retry logic for aborted transactions and clean up redundant code * fix: fixed linting errors * feat: support GRAPH and pipe syntax in dbapi (#1285) Recognize GRAPH and pipe syntax queries as valid queries in dbapi. * chore: Add Custom OpenTelemetry Exporter in for Service Metrics (#1273) * chore: Add Custom OpenTelemetry Exporter in for Service Metrics * Updated copyright dates to 2025 --------- Co-authored-by: rahul2393 <irahul@google.com> * fix: removing retry logic for RST_STREAM errors from _retry_on_aborted_exception handler --------- Co-authored-by: Knut Olav Løite <koloite@gmail.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lester Szeto <lester.szeto@gmail.com> Co-authored-by: rahul2393 <irahul@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an implementation for an OpenTelemetry exporter to send the following service metrics that are already present in the Go and Java clients:
operation_latenciesoperation_countattempt_latenciesattempt_countgfe_latencygfe_missing_header_countFiles added to a
metricsfolder in/google/cloud/spanner_v1/metricsmetrics_exporter.py- The definition for the exporterconstants.py- Constant values such as metric and label names to be used by both the exporter and eventual implementing code.Based on regular client Google Cloud Monitoring exporter found here
note: CLA not signed yet, as there's a settings issue. Will have it submitted soon.
note2: Linter runs with no issues, currently working on generating code coverage report to verify full coverage.