Skip to content

feat: metricsTracer implementation #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat: metricsTracer implementation #1291

merged 1 commit into from
Jan 24, 2025

Conversation

lszinv
Copy link
Contributor

@lszinv lszinv commented Jan 17, 2025 •
edited
Loading

Changes to add MetricsTracer class to be used by interceptors in Spanner GRPC client.

Changes are mirrored from Python GAX until the GAX changes are merged, per discussion with @rahul2393

@lszinv lszinv requested review from a team as code owners January 17, 2025 08:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 17, 2025
@lszinv lszinv closed this Jan 17, 2025
@lszinv lszinv reopened this Jan 17, 2025
@lszinv lszinv force-pushed the lsz/GSO-36/GAX_changes branch from fd1d069 to 5002654 Compare January 17, 2025 18:54
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 18, 2025
@rahul2393 rahul2393 changed the title Feat: MetricsTracer implementation feat: MetricsTracer implementation Jan 22, 2025
@rahul2393 rahul2393 changed the title feat: MetricsTracer implementation feat: metricsTracer implementation Jan 22, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@rahul2393
Copy link
Contributor

@lszinv There are lint failures

would reformat /tmpfs/src/github/python-spanner/google/cloud/spanner_v1/metrics/metrics_tracer.py
would reformat /tmpfs/src/github/python-spanner/tests/unit/test_metrics_tracer.py

Oh no! 💥 💔 💥
2 files would be reformatted, 174 files would be left unchanged.
nox > Command black --check docs google tests noxfile.py setup.py failed with exit code 1
nox > Session lint failed.

@lszinv lszinv force-pushed the lsz/GSO-36/GAX_changes branch from 7373f33 to c21e2d1 Compare January 22, 2025 15:16
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2025
@rahul2393 rahul2393 merged commit 8fbde6b into googleapis:main Jan 24, 2025
10 of 12 checks passed
@release-please release-please bot mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

@bhatt4982 bhatt4982

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lszinv @rahul2393 @yoshi-kokoro @bhatt4982
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy