Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

feat: add samples and tests for adding captions to a job #131

Merged
merged 3 commits into from
Feb 4, 2022
Merged

feat: add samples and tests for adding captions to a job #131

merged 3 commits into from
Feb 4, 2022

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Jan 25, 2022 •
edited
Loading

Needs https://cloud.google.com/transcoder/images/caption.srt uploaded to the test bucket for the tests to pass.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes 210892114

@irataxy irataxy requested review from a team as code owners January 25, 2022 00:47
@product-auto-label product-auto-label bot added the api: transcoder Issues related to the googleapis/python-video-transcoder API. label Jan 25, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jan 25, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 25, 2022
@busunkim96
Copy link
Contributor

Hey @irataxy, do you have an AI DPE helping you with getting that new file to the bucket or do you need someone else to look into that?

@irataxy irataxy added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@irataxy irataxy added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@nicain nicain added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2022
@irataxy irataxy requested a review from a team as a code owner February 1, 2022 23:23
@irataxy
Copy link
Contributor Author

irataxy commented Feb 2, 2022

Hey @irataxy, do you have an AI DPE helping you with getting that new file to the bucket or do you need someone else to look into that?

@nicain added it so this should be ready for review.

busunkim96
busunkim96 approved these changes Feb 4, 2022
View reviewed changes
@irataxy irataxy merged commit e30431f into googleapis:main Feb 4, 2022
@release-please release-please bot mentioned this pull request Feb 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: transcoder Issues related to the googleapis/python-video-transcoder API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irataxy @busunkim96 @nicain @yoshi-kokoro
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy