Skip to content

Use ConcurrentDictionary in ValidationContext #4085 #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2025

Conversation

clangelov
Copy link
Contributor

Move from IReadOnlyDicrionary to IDictionary
and replaced Dictionary with ConcurrentDictionary

check Related Issue

@Shane32
Copy link
Member

Shane32 commented Jul 16, 2025

Looks about right, although this feature is slotted for v9 due to breaking changes in the API. The develop branch will hold the v9 features until its released, while master is v8 features. We also need to add a migration file listing the breaking changes.

@Shane32 Shane32 changed the base branch from master to develop July 16, 2025 19:59
@Shane32
Copy link
Member

Shane32 commented Jul 16, 2025

To add a migration document, add migration9.md in the same format as migration8.md, and modify sitemap.yml also

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.73%. Comparing base (69c8cbc) to head (e2c7185).
Report is 164 commits behind head on develop.

Files with missing lines Patch % Lines
...phQL/Validation/FieldArgumentsValidationContext.cs 0.00% 2 Missing ⚠️
src/GraphQL/Execution/ExecutionStrategy.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4159      +/-   ##
===========================================
- Coverage    84.30%   83.73%   -0.58%     
===========================================
  Files          442      532      +90     
  Lines        20742    24540    +3798     
  Branches      3243     3877     +634     
===========================================
+ Hits         17487    20549    +3062     
- Misses        2474     2939     +465     
- Partials       781     1052     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clangelov
Copy link
Contributor Author

@Shane32, now the PR should be in a better state

@Shane32
Copy link
Member

Shane32 commented Jul 18, 2025

Thanks! I should be able to review this tomorrow.

@Shane32 Shane32 merged commit fcf6662 into graphql-dotnet:develop Jul 26, 2025
11 checks passed
@Shane32
Copy link
Member

Shane32 commented Jul 26, 2025

Thanks @clangelov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy