-
-
Notifications
You must be signed in to change notification settings - Fork 43
Docusaurus version upgrade to 2.4.1 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. docusaurus-plugin-sass"from ^0.1.08 to 0.1.11 2. config modification 3. Implement Navbar/index.js accordingly
Merge with updated version
@donghwipark have you run the new changes against the website? I'm seeing a lot of differences. For example, the navbar isn't pinned to the top of the window when you scroll any more. |
@phated I couldn't realize that defect. I will compare with current web and please let me know defects you realised. Will fix and re-commit. |
@phated I fixed the CSS and pushed, please have a look and give me any comments if you need. Thank you |
I found some changes on text size after the upgrade. Seems default css has changed will update and commit |
@phated fixed some css after comparing between the new version and current version. |
@donghwipark that's awesome! Thanks for inspecting. Will you also please update the other dependencies that have newer versions? I noticed that Also, please regenerate and commit the package-lock.json using |
@phated Sure Thank you for the guide! |
Replaced by #149 |
I updated to docusaurus v 2.4.1 Please check and comment if there is any fix requires. Thank you