Skip to content

FFM-11935 Add with_httpx_args option #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2024
Merged

FFM-11935 Add with_httpx_args option #106

merged 3 commits into from
Aug 27, 2024

Conversation

erdirowlands
Copy link
Contributor

@erdirowlands erdirowlands commented Aug 27, 2024

What

Integrates PR from customer ZeroFlucs #105

Allows a user to supply the underlying http client args such as proxies or transport etc. The open api gen code already allowed for this, so it was a case that we didn’t expose this initially.

If an invalid option is supplied, like idontexist, the SDK fails to initialize and serves defaults. Documentation and sample has been updated to advise of this

Testing

  • Tested proxies param:
    • Setup a local Charles proxy which forwarded requests to Harness SaaS and the SDK authenticated correctly.

@erdirowlands erdirowlands changed the title FFM-11935 FFM-11935 Add with_httpx_args option Aug 27, 2024
@erdirowlands erdirowlands requested a review from akiraqb August 27, 2024 14:35
@erdirowlands erdirowlands merged commit d32a599 into main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy