Skip to content

FFM-11655 Sort AND/OR rules when getting group #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

erdirowlands
Copy link
Contributor

@erdirowlands erdirowlands commented Jun 24, 2024

What

  • Move the AND/OR rules sorting outside of the critical evaluation path into the point we get the group in set_segment
  • Also fixes compatability issues with Python 3.7. The re-generated API spec from [FFM-11244] - Target v2: Adding support for AND/OR in clauses #90 brought in code not compatible with 3.7. This fix adds a backport for typings so the SDK works correctly on 3.7 again.

Why

Avoid the cost of sorting multiple times during evaluations when it is unnecessary, which can add evaluation latency.

Testing

TestGrid

Copy link
Contributor

@conormurray95 conormurray95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erdirowlands erdirowlands merged commit 04ce9c0 into main Jun 25, 2024
1 check passed
@erdirowlands erdirowlands deleted the FFM-11655 branch June 25, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy