Added share service to Tessie #148575
Added share service to Tessie #148575
Conversation
|
Hey there @Bre77, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Thanks for the quick approval! Yes, as written in the description, I'll work on the tests on Sunday and/or Monday. That's why the PR is still a draft. I just wanted to have a review on the main part. Thanks! |
154102d to
682166c
Compare
|
The PR is now ready for a final review, thanks! |
| wait_for_completion=wait_for_completion, | ||
| ) | ||
| except ClientResponseError as e: | ||
| raise HomeAssistantError from e |
There was a problem hiding this comment.
can we add a little text to explain that we failed?
There was a problem hiding this comment.
I re-used the same error management logic from https://github.com/home-assistant/core/blob/dev/homeassistant/components/tessie/entity.py#L105. This can be enhanced in both location in a subsequent PR?
| except ClientResponseError as e: | ||
| raise HomeAssistantError from e | ||
| if response["result"] is False: | ||
| name: str = getattr(device, "name", device.id) |
There was a problem hiding this comment.
See my comment above
| else: | ||
| raise HomeAssistantError( | ||
| translation_domain=DOMAIN, | ||
| translation_key="invalid_device", | ||
| translation_placeholders={"device_id": device_id}, | ||
| ) |
There was a problem hiding this comment.
I think we can do this with a quick return, or to incorporate this into the function we use to fetch the rest
There was a problem hiding this comment.
See my comment above
| locale: | ||
| required: false | ||
| default: "en-US" | ||
| selector: | ||
| text: | ||
| retry_duration: | ||
| required: false | ||
| default: 40 | ||
| selector: | ||
| number: | ||
| min: 0 | ||
| max: 90 | ||
| unit_of_measurement: seconds | ||
| wait_for_completion: | ||
| required: false | ||
| default: true | ||
| selector: | ||
| boolean: |
There was a problem hiding this comment.
why do we ask for locale, retry duration and completion? We should pick something that would work for everyone
There was a problem hiding this comment.
Those are inputs from the Tessie's web service. locale is the less important one here. But the two other will drastically change the way the web service will behave and have to be exposed to the user.
| "services": { | ||
| "share": { | ||
| "name": "Share", | ||
| "description": "Shares an address, latitude/longitude or video URL to the vehicle.", |
There was a problem hiding this comment.
How should and address be formatted? Or lat/lon? I would argue that these are separate actions which require separate validation
There was a problem hiding this comment.
Tesla (not Tessie) filter and validate what they allow to be sent to the car server-side. It's a single web service. We can't/don't want to try to validate this on client-side.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
This adds a new
shareservice to send addresses or video URL to the vehicles:Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: